Browse Source

Refactor comments, still

imwald
Nuša Pukšič 3 months ago
parent
commit
2bea95b769
  1. 41
      assets/controllers/comments_mercure_controller.js
  2. 20
      templates/components/Organisms/Comments.html.twig

41
assets/controllers/comments_mercure_controller.js

@ -1,14 +1,23 @@
import { Controller } from "@hotwired/stimulus"; import { Controller } from "@hotwired/stimulus";
import { getComponent } from "@symfony/ux-live-component";
export default class extends Controller { export default class extends Controller {
static values = { coordinate: String } static values = { coordinate: String }
static targets = ["list", "loading"] static targets = ["list", "loading"]
connect() { async connect() {
this._liveRoot = this.element.closest( // this.element IS the Live root now
'[data-controller~="live"]' this.component = await getComponent(this.element);
);
// Optional: hook for spinner polish
this.component.on('render:started', () => this._showLoading());
this.component.on('render:finished', () => this._hideLoading());
// Initial render from cache so UI isn’t empty
this._showLoading();
await this.component.render();
// Subscribe to Mercure and re-render on each ping
const hubUrl = window.MercureHubUrl || document.querySelector('meta[name="mercure-hub"]')?.content; const hubUrl = window.MercureHubUrl || document.querySelector('meta[name="mercure-hub"]')?.content;
if (!hubUrl) return; if (!hubUrl) return;
@ -16,21 +25,23 @@ export default class extends Controller {
url.searchParams.append('topic', `/comments/${this.coordinateValue}`); url.searchParams.append('topic', `/comments/${this.coordinateValue}`);
this.es = new EventSource(url.toString()); this.es = new EventSource(url.toString());
this.es.onmessage = (event) => this._pushToLive(event.data); this.es.onmessage = async (msg) => {
this._showLoading();
this.component.set('payloadJson', JSON.stringify(msg.data));
await this.component.render(); // Live re-hydrates from your server/cache
};
} }
disconnect() { disconnect() {
if (this.es) try { this.es.close(); } catch {} try { this.es?.close(); } catch {}
} }
_pushToLive(jsonString) { _showLoading() {
if (!this._liveRoot) return; if (this.hasLoadingTarget) this.loadingTarget.style.display = '';
// Find the hidden input bound to the LiveProp if (this.hasListTarget) this.listTarget.style.opacity = '0.6';
const input = this._liveRoot.querySelector('input[type="hidden"][data-model="payloadJson"]'); }
if (!input) return; _hideLoading() {
if (this.hasLoadingTarget) this.loadingTarget.style.display = 'none';
// Set value and dispatch an 'input' event so Live updates & re-renders if (this.hasListTarget) this.listTarget.style.opacity = '';
input.value = jsonString;
input.dispatchEvent(new Event('change', { bubbles: true }));
} }
} }

20
templates/components/Organisms/Comments.html.twig

@ -1,17 +1,14 @@
<div {% set existing = attributes.all()['data-controller'] ?? '' %}
{{ attributes }} {% set merged = (existing ? existing ~ ' ' : '') ~ 'comments-mercure' %}
data-comments-coordinate="{{ current }}">
<input type="hidden"
data-model="payloadJson"
value="{{ payloadJson|default('') }}" />
<div <div
class="comments" {{ attributes.add('data-controller', merged) }}
data-controller="comments-mercure"
data-comments-mercure-coordinate-value="{{ current }}" data-comments-mercure-coordinate-value="{{ current }}"
data-comments-mercure-target="root" data-comments-mercure-target="loading"
id="comments-{{ current|e('html_attr') }}"> data-comments-mercure-target="list"
id="comments-{{ current|e('html_attr') }}"
class="comments"
>
{% if loading %} {% if loading %}
<div class="comments-loading" data-comments-mercure-target="loading">Loading comments…</div> <div class="comments-loading" data-comments-mercure-target="loading">Loading comments…</div>
@ -62,4 +59,3 @@
</div> </div>
</div> </div>
</div>

Loading…
Cancel
Save