From baa6716fc2c2e2518df1ef5213f778e5ce3fb4a3 Mon Sep 17 00:00:00 2001 From: Silberengel Date: Wed, 3 Dec 2025 16:24:16 +0100 Subject: [PATCH] display og image, not favicon, as fallback --- src/components/WebPreview/index.tsx | 1 + src/services/web.service.ts | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/components/WebPreview/index.tsx b/src/components/WebPreview/index.tsx index 3b45679..61035a6 100644 --- a/src/components/WebPreview/index.tsx +++ b/src/components/WebPreview/index.tsx @@ -475,6 +475,7 @@ export default function WebPreview({ url, className }: { url: string; className? // Fallback to OG image from website if event doesn't have an image // The OG image is already converted to absolute URL by useFetchWebMetadata + // Prioritize: event image tag > OG image from URL metadata (not favicon) const displayImage = eventImageThumbnail || image // Extract bookstr metadata if applicable diff --git a/src/services/web.service.ts b/src/services/web.service.ts index ea625ee..c7d327f 100644 --- a/src/services/web.service.ts +++ b/src/services/web.service.ts @@ -129,7 +129,15 @@ class WebService { const basePath = urlObj.pathname.substring(0, urlObj.pathname.lastIndexOf('/') + 1) image = `${urlObj.protocol}//${urlObj.host}${basePath}${image}` } - logger.info('[WebService] Converted relative image URL to absolute', { originalImage: (doc.querySelector('meta[property="og:image"]') as HTMLMetaElement | null)?.content, absoluteImage: image }) + + // Filter out favicon URLs - we want OG images, not favicons + const imageLower = image.toLowerCase() + if (imageLower.includes('/favicon') || imageLower.endsWith('/favicon.ico') || imageLower.endsWith('/favicon.svg')) { + logger.warn('[WebService] Filtered out favicon URL from OG image', { url, image }) + image = undefined + } else { + logger.info('[WebService] Converted relative image URL to absolute', { originalImage: (doc.querySelector('meta[property="og:image"]') as HTMLMetaElement | null)?.content, absoluteImage: image }) + } } catch (error) { logger.warn('[WebService] Failed to convert relative image URL', { image, url, error }) // Keep original image URL if conversion fails