From 7f5379a6550a72c5a5ecabfc49b53a3b2b8d2a14 Mon Sep 17 00:00:00 2001
From: Silberengel <silberengel7@protonmail.com>
Date: Sun, 19 Apr 2026 12:27:38 +0200
Subject: [PATCH] enforce strict typing

---
 pyproject.toml                        |  9 +++--
 src/imwald/core/accounts_store.py     | 10 ++++--
 src/imwald/core/author_html.py        |  2 +-
 src/imwald/core/database.py           | 45 ++++++++++++++---------
 src/imwald/core/kind0_profile.py      |  7 ++--
 src/imwald/core/md_render.py          | 14 ++++----
 src/imwald/core/nostr_crypto.py       |  7 ++--
 src/imwald/core/nostr_engine.py       | 15 +++++---
 src/imwald/core/nostr_nip96_upload.py | 17 ++++++---
 src/imwald/core/nostr_publish.py      |  7 ++--
 src/imwald/core/nostr_types.py        |  6 ++--
 src/imwald/core/ranker.py             |  5 +--
 src/imwald/core/relay_list.py         | 33 +++++++++--------
 src/imwald/core/relay_manager.py      | 51 ++++++++++++++-------------
 src/imwald/ui/composer_dialog.py      | 12 ++++---
 src/imwald/ui/db_admin_page.py        | 18 +++++-----
 src/imwald/ui/feed_page.py            | 27 +++++++++++---
 src/imwald/ui/main_window.py          | 18 ++++++----
 src/imwald/ui/notifications_page.py   |  4 ++-
 src/imwald/ui/onboarding_wizard.py    | 38 +++++++++++++-------
 src/imwald/ui/search_page.py          |  2 +-
 tests/test_kind30000_lists.py         | 19 ++++++++--
 typings/quickjs.pyi                   |  5 +++
 23 files changed, 235 insertions(+), 136 deletions(-)
 create mode 100644 typings/quickjs.pyi

diff --git a/pyproject.toml b/pyproject.toml
index 3088a63..28383bb 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -47,8 +47,7 @@ pythonVersion = "3.11"
 # So third-party stubs (e.g. Pillow → ``PIL``) resolve when using ``.venv`` at the repo root.
 venvPath = "."
 venv = ".venv"
-# Desktop app + sqlite/Qt stubs surface a lot of ``Any``; keep checks useful without IDE noise.
-typeCheckingMode = "standard"
-reportMissingTypeStubs = "none"
-reportAny = "none"
-reportExplicitAny = "none"
+# Strict static typing; partial stubs live under ``typings/`` (``stubPath``).
+typeCheckingMode = "strict"
+reportMissingTypeStubs = "error"
+stubPath = "typings"
diff --git a/src/imwald/core/accounts_store.py b/src/imwald/core/accounts_store.py
index e720991..93f522c 100644
--- a/src/imwald/core/accounts_store.py
+++ b/src/imwald/core/accounts_store.py
@@ -3,9 +3,9 @@
 from __future__ import annotations
 
 import json
-from dataclasses import asdict, dataclass
+from dataclasses import dataclass
 from pathlib import Path
-from typing import Any
+from typing import Any, cast
 
 from coincurve import PrivateKey
 
@@ -52,7 +52,11 @@ def load_accounts(path: Path | None = None) -> list[StoredAccount]:
     data = json.loads(p.read_text(encoding="utf-8"))
     if not isinstance(data, list):
         return []
-    return [StoredAccount.from_json(x) for x in data if isinstance(x, dict)]
+    out_acct: list[StoredAccount] = []
+    for x in cast(list[object], data):
+        if isinstance(x, dict):
+            out_acct.append(StoredAccount.from_json(cast(dict[str, Any], x)))
+    return out_acct
 
 
 def save_accounts(accounts: list[StoredAccount], path: Path | None = None) -> None:
diff --git a/src/imwald/core/author_html.py b/src/imwald/core/author_html.py
index 2568447..8f0a955 100644
--- a/src/imwald/core/author_html.py
+++ b/src/imwald/core/author_html.py
@@ -8,7 +8,7 @@ from imwald.core.kind0_profile import display_name_from_profile
 
 
 def safe_http_url(u: str | None) -> str | None:
-    if not u or not isinstance(u, str):
+    if not u:
         return None
     u = u.strip()
     if u.startswith("https://") or u.startswith("http://"):
diff --git a/src/imwald/core/database.py b/src/imwald/core/database.py
index 3053fa9..d3c0633 100644
--- a/src/imwald/core/database.py
+++ b/src/imwald/core/database.py
@@ -7,7 +7,8 @@ import sqlite3
 import time
 from contextlib import contextmanager
 from pathlib import Path
-from typing import Any, Generator, Iterable, TypedDict, cast
+from collections.abc import Generator, Iterable
+from typing import Any, TypedDict, cast
 
 SCHEMA_VERSION = 2
 
@@ -164,7 +165,7 @@ CREATE INDEX IF NOT EXISTS idx_feed_views_event ON feed_views(event_id);
 
 class Database:
     def __init__(self, path: Path) -> None:
-        self.path = path
+        self.path: Path = path
         path.parent.mkdir(parents=True, exist_ok=True)
         self._conn: sqlite3.Connection | None = None
 
@@ -233,7 +234,12 @@ class Database:
     ) -> None:
         """Insert or replace event; expand tags into tags table."""
         eid = ev["id"]
-        tags = ev.get("tags") or []
+        raw_tags = ev.get("tags")
+        tags: list[list[str]] = (
+            cast(list[list[str]], raw_tags)
+            if isinstance(raw_tags, list)
+            else []
+        )
         tags_json = json.dumps(tags, ensure_ascii=False)
         raw = json.dumps(ev, ensure_ascii=False)
         with self.write_lock() as c:
@@ -314,7 +320,7 @@ class Database:
             try:
                 ev = json.loads(raw)
                 if isinstance(ev, dict):
-                    return ev
+                    return cast(dict[str, Any], ev)
             except json.JSONDecodeError:
                 pass
         return {
@@ -324,7 +330,7 @@ class Database:
             "kind": row["kind"],
             "content": row["content"] or "",
             "sig": row["sig"],
-            "tags": json.loads(row["tags_json"] or "[]"),
+            "tags": cast(list[list[str]], json.loads(row["tags_json"] or "[]")),
         }
 
     def get_event(self, event_id: str) -> StoredEventRow | None:
@@ -411,7 +417,7 @@ class Database:
                     "kind": row["kind"],
                     "content": row["content"],
                     "sig": row["sig"],
-                    "tags": json.loads(row["tags_json"] or "[]"),
+                    "tags": cast(list[list[str]], json.loads(row["tags_json"] or "[]")),
                     "source_relay": row["source_relay"],
                 }
             )
@@ -453,20 +459,25 @@ class Database:
         try:
             data = json.loads(content)
             if isinstance(data, list):
-                for x in data:
+                for x in cast(list[object], data):
                     if isinstance(x, str) and len(x) == 64:
                         out.add(x.lower())
                     elif isinstance(x, dict) and "pubkey" in x:
-                        pk = str(x["pubkey"])
+                        xd = cast(dict[str, object], x)
+                        pk = str(xd.get("pubkey", ""))
                         if len(pk) == 64:
                             out.add(pk.lower())
         except json.JSONDecodeError:
             pass
         try:
-            tags = json.loads(row["tags_json"] or "[]")
-            for t in tags:
-                if t and t[0] == "p" and len(t) > 1 and len(t[1]) == 64:
-                    out.add(str(t[1]).lower())
+            tags_raw = json.loads(row["tags_json"] or "[]")
+            if isinstance(tags_raw, list):
+                for t_obj in cast(list[object], tags_raw):
+                    if not isinstance(t_obj, list) or not t_obj:
+                        continue
+                    row = cast(list[object], t_obj)
+                    if str(row[0]) == "p" and len(row) > 1 and len(str(row[1])) == 64:
+                        out.add(str(row[1]).lower())
         except json.JSONDecodeError:
             pass
         return out
@@ -512,7 +523,7 @@ class Database:
                 "kind": r["kind"],
                 "content": r["content"],
                 "sig": r["sig"],
-                "tags": json.loads(r["tags_json"] or "[]"),
+                "tags": cast(list[list[str]], json.loads(r["tags_json"] or "[]")),
             }
             for r in cur
         ]
@@ -527,7 +538,7 @@ class Database:
             """,
             (q, q, q, limit),
         )
-        rows = []
+        rows: list[dict[str, Any]] = []
         for row in cur:
             rows.append(
                 {
@@ -537,7 +548,7 @@ class Database:
                     "kind": row["kind"],
                     "content": row["content"],
                     "sig": row["sig"],
-                    "tags": json.loads(row["tags_json"] or "[]"),
+                    "tags": cast(list[list[str]], json.loads(row["tags_json"] or "[]")),
                 }
             )
         return rows
@@ -558,7 +569,7 @@ class Database:
                 "kind": r["kind"],
                 "content": r["content"],
                 "sig": r["sig"],
-                "tags": json.loads(r["tags_json"] or "[]"),
+                "tags": cast(list[list[str]], json.loads(r["tags_json"] or "[]")),
             }
             for r in cur
         ]
@@ -599,7 +610,7 @@ class Database:
 
     def get_latest_kind0_profiles(self, pubkeys: Iterable[str]) -> dict[str, Kind0ProfileSummary]:
         """Most recent kind-0 ``content`` per pubkey (lowercase hex keys)."""
-        pks = [p.lower() for p in pubkeys if isinstance(p, str) and len(p) == 64]
+        pks = [p.lower() for p in pubkeys if len(p) == 64]
         if not pks:
             return {}
         placeholders = ",".join("?" * len(pks))
diff --git a/src/imwald/core/kind0_profile.py b/src/imwald/core/kind0_profile.py
index 9ab57f3..6bc5b76 100644
--- a/src/imwald/core/kind0_profile.py
+++ b/src/imwald/core/kind0_profile.py
@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import json
-from typing import Any
+from typing import cast
 
 
 def parse_kind0_profile(content: str) -> dict[str, str | None]:
@@ -17,11 +17,12 @@ def parse_kind0_profile(content: str) -> dict[str, str | None]:
         "banner": None,
     }
     try:
-        d: Any = json.loads(content or "")
+        raw = json.loads(content or "")
     except json.JSONDecodeError:
         return empty
-    if not isinstance(d, dict):
+    if not isinstance(raw, dict):
         return empty
+    d = cast(dict[str, object], raw)
 
     def pick(*keys: str) -> str | None:
         for k in keys:
diff --git a/src/imwald/core/md_render.py b/src/imwald/core/md_render.py
index 5ce42e6..6f0557e 100644
--- a/src/imwald/core/md_render.py
+++ b/src/imwald/core/md_render.py
@@ -17,6 +17,7 @@ from imwald.core.nostr_entity_render import preprocess_nostr_entities
 
 if TYPE_CHECKING:
     from imwald.core.database import Database
+    from quickjs import Context
 
 log = logging.getLogger(__name__)
 
@@ -27,7 +28,7 @@ _STANDALONE_IMAGE_URL = re.compile(
 )
 
 _MARKED_PATH = Path(__file__).resolve().parents[1] / "ui" / "assets" / "vendor" / "marked.min.js"
-_qjs_ctx = None
+_qjs_ctx: Context | None = None
 _marked_load_failed = False
 
 _nh3_attrs_merged: dict[str, set[str]] | None = None
@@ -67,11 +68,10 @@ def _nh3_attributes() -> dict[str, set[str]]:
     if _nh3_attrs_merged is None:
         raw = cast(MutableMapping[str, set[str]], deepcopy(nh3.ALLOWED_ATTRIBUTES))
         for tag in ("span", "div"):
-            s = raw.get(tag)
-            if s is None:
-                s = set()
-                raw[tag] = s
-            s.update({"class", "style", "title"})
+            cur = raw.get(tag)
+            tag_set: set[str] = set(cur) if cur is not None else set()
+            raw[tag] = tag_set
+            tag_set.update({"class", "style", "title"})
         img_a = raw.get("img")
         if img_a is not None:
             img_a.add("style")
@@ -87,7 +87,7 @@ def _nh3_clean(html: str) -> str:
     )
 
 
-def _marked_quickjs_ctx():
+def _marked_quickjs_ctx() -> Context | None:
     """Singleton QuickJS context with ``marked`` loaded, or None if unavailable."""
     global _qjs_ctx, _marked_load_failed
     if _marked_load_failed:
diff --git a/src/imwald/core/nostr_crypto.py b/src/imwald/core/nostr_crypto.py
index b0a64c2..5ef609e 100644
--- a/src/imwald/core/nostr_crypto.py
+++ b/src/imwald/core/nostr_crypto.py
@@ -4,7 +4,7 @@ from __future__ import annotations
 
 import json
 from hashlib import sha256
-from typing import Any
+from typing import Any, cast
 
 from coincurve import PrivateKey
 from coincurve.keys import PublicKeyXOnly
@@ -43,9 +43,10 @@ def verify_nostr_event(ev: dict[str, Any]) -> bool:
     required = ("id", "pubkey", "created_at", "kind", "tags", "content", "sig")
     if not all(k in ev for k in required):
         return False
-    tags = ev["tags"]
-    if not isinstance(tags, list):
+    tags_raw = ev["tags"]
+    if not isinstance(tags_raw, list):
         return False
+    tags = cast(list[list[str]], tags_raw)
     pk_hex = str(ev["pubkey"]).lower()
     if len(pk_hex) != 64 or any(c not in "0123456789abcdef" for c in pk_hex):
         return False
diff --git a/src/imwald/core/nostr_engine.py b/src/imwald/core/nostr_engine.py
index 85234eb..9d69f64 100644
--- a/src/imwald/core/nostr_engine.py
+++ b/src/imwald/core/nostr_engine.py
@@ -7,7 +7,7 @@ import json
 import logging
 import threading
 import time
-from typing import Any
+from typing import Any, cast
 
 from PySide6.QtCore import QObject, Signal
 
@@ -123,14 +123,19 @@ class NostrEngine(QObject):
 
     @staticmethod
     def apply_ingest_to_db(db: Database, ev: dict[str, Any], source_relay: str | None = None) -> None:
-        if not isinstance(ev, dict) or "id" not in ev:
+        if "id" not in ev:
             return
         if not verify_nostr_event(ev):
             return
         if ev.get("kind") == 5:
-            for t in ev.get("tags") or []:
-                if t and t[0] == "e" and len(t) > 1:
-                    db.tombstone_event(t[1])
+            raw_tags = ev.get("tags")
+            tag_rows: list[object] = cast(list[object], raw_tags) if isinstance(raw_tags, list) else []
+            for t_obj in tag_rows:
+                if not isinstance(t_obj, list):
+                    continue
+                t = cast(list[object], t_obj)
+                if t and str(t[0]) == "e" and len(t) > 1:
+                    db.tombstone_event(str(t[1]))
         db.upsert_event(ev, source_relay=source_relay)
 
     def publish_kind0_and_lists(
diff --git a/src/imwald/core/nostr_nip96_upload.py b/src/imwald/core/nostr_nip96_upload.py
index fd42f7f..db1357b 100644
--- a/src/imwald/core/nostr_nip96_upload.py
+++ b/src/imwald/core/nostr_nip96_upload.py
@@ -10,7 +10,7 @@ import time
 import urllib.error
 import urllib.request
 from hashlib import sha256
-from typing import Any
+from typing import Any, cast
 
 from imwald.core.nostr_crypto import build_signed_event
 
@@ -126,11 +126,18 @@ def upload_image_nip96_nostr_build(
     data: dict[str, Any] = json.loads(raw)
     if data.get("status") != "success":
         raise RuntimeError(data.get("message") or "nostr.build upload unsuccessful")
-    nip94 = data.get("nip94_event") or {}
-    tags = nip94.get("tags") or []
-    if not isinstance(tags, list):
+    nip94_raw: object = data.get("nip94_event") or {}
+    if not isinstance(nip94_raw, dict):
+        nip94_raw = {}
+    nip94 = cast(dict[str, Any], nip94_raw)
+    tags_raw: object = nip94.get("tags") or []
+    if not isinstance(tags_raw, list):
         raise RuntimeError("invalid nip94_event.tags in upload response")
-    url = next((str(t[1]) for t in tags if isinstance(t, list) and len(t) >= 2 and str(t[0]) == "url"), None)
+    tags: list[list[str]] = []
+    for item in cast(list[object], tags_raw):
+        if isinstance(item, list):
+            tags.append([str(x) for x in cast(list[object], item)])
+    url = next((row[1] for row in tags if len(row) >= 2 and row[0] == "url"), None)
     if not url:
         raise RuntimeError("no url tag in nip94_event response")
     return url, tags
diff --git a/src/imwald/core/nostr_publish.py b/src/imwald/core/nostr_publish.py
index cdd1c28..0d4d741 100644
--- a/src/imwald/core/nostr_publish.py
+++ b/src/imwald/core/nostr_publish.py
@@ -5,7 +5,7 @@ from __future__ import annotations
 import asyncio
 import json
 import logging
-from typing import Any
+from typing import Any, cast
 
 import websockets
 
@@ -29,9 +29,10 @@ async def publish_to_relays(urls: list[str], event: dict[str, Any], timeout: flo
             async with websockets.connect(ws_url, ping_interval=20, open_timeout=timeout) as ws:
                 await ws.send(json.dumps(["EVENT", event]))
                 raw = await asyncio.wait_for(ws.recv(), timeout=timeout)
-                msg = json.loads(raw)
+                msg: object = json.loads(raw)
                 # NIP-01: ["OK", <event_id>, <bool>, <message optional>]
-                ok = isinstance(msg, list) and len(msg) >= 3 and msg[0] == "OK" and msg[2] is True
+                wire = cast(list[object], msg) if isinstance(msg, list) else []
+                ok = len(wire) >= 3 and wire[0] == "OK" and wire[2] is True
                 results[url] = ok
         except Exception as e:  # noqa: BLE001
             log.info("publish fail %s: %s", url, e)
diff --git a/src/imwald/core/nostr_types.py b/src/imwald/core/nostr_types.py
index 2c1c5f0..9fd870e 100644
--- a/src/imwald/core/nostr_types.py
+++ b/src/imwald/core/nostr_types.py
@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-from dataclasses import dataclass, field
-from typing import Any
+from dataclasses import dataclass
+from typing import Any, cast
 
 
 @dataclass
@@ -18,7 +18,7 @@ class NostrEvent:
     def from_row(cls, row: dict[str, Any]) -> NostrEvent:
         import json
 
-        tags = json.loads(row["tags_json"] or "[]")
+        tags = cast(list[list[str]], json.loads(row["tags_json"] or "[]"))
         return cls(
             id=row["id"],
             pubkey=row["pubkey"],
diff --git a/src/imwald/core/ranker.py b/src/imwald/core/ranker.py
index 739d83e..252477f 100644
--- a/src/imwald/core/ranker.py
+++ b/src/imwald/core/ranker.py
@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import json
-from typing import Any
+from typing import Any, cast
 
 from imwald.core.relay_policy import is_wisp_trending_relay_url
 
@@ -66,7 +66,8 @@ class Ranker:
         if sr and is_wisp_trending_relay_url(sr):
             score += WEIGHT_TRENDING_RELAY
             why["trending_relay"] = WEIGHT_TRENDING_RELAY
-        tags = ev.get("tags") or []
+        raw_tags: object = ev.get("tags") or []
+        tags: list[list[str]] = cast(list[list[str]], raw_tags) if isinstance(raw_tags, list) else []
         if _tags_contain_repost(tags):
             score += WEIGHT_BOOST
             why["repost_or_quote_hint"] = WEIGHT_BOOST
diff --git a/src/imwald/core/relay_list.py b/src/imwald/core/relay_list.py
index b3cfafe..2bd9dad 100644
--- a/src/imwald/core/relay_list.py
+++ b/src/imwald/core/relay_list.py
@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import Any
+from typing import cast
 
 from imwald.core.database import Database
 from imwald.core.relay_policy import DEFAULT_READ_RELAYS, DEFAULT_WRITE_RELAYS
@@ -26,7 +26,7 @@ def _dedupe_preserve(urls: list[str]) -> list[str]:
     return out
 
 
-def parse_kind10002_tags(tags: Any) -> tuple[list[str], list[str]]:
+def parse_kind10002_tags(tags: object) -> tuple[list[str], list[str]]:
     """
     Parse NIP-65 `r` tags into (read_urls, write_urls).
     - ``["r", url]`` or unknown third value → both read and write.
@@ -35,34 +35,39 @@ def parse_kind10002_tags(tags: Any) -> tuple[list[str], list[str]]:
     """
     if not isinstance(tags, list):
         return [], []
+    wire = cast(list[object], tags)
 
     read: list[str] = []
     write: list[str] = []
     i = 0
-    while i < len(tags):
-        t = tags[i]
+    while i < len(wire):
+        t = wire[i]
         i += 1
-        if not t or not isinstance(t, list) or len(t) < 2:
+        if not isinstance(t, list):
             continue
-        if str(t[0]) != "r":
+        row = cast(list[object], t)
+        if len(row) < 2:
             continue
-        url = str(t[1]).strip()
+        if str(row[0]) != "r":
+            continue
+        url = str(row[1]).strip()
         if not _is_ws_relay_url(url):
             continue
 
         mode = "both"
-        if len(t) >= 3:
-            m = str(t[2]).lower()
+        if len(row) >= 3:
+            m = str(row[2]).lower()
             if m == "read":
                 mode = "read"
             elif m == "write":
                 mode = "write"
         else:
-            if i < len(tags):
-                nxt = tags[i]
-                if nxt and isinstance(nxt, list) and len(nxt) >= 2:
-                    name = str(nxt[0]).lower()
-                    val = str(nxt[1]).lower()
+            if i < len(wire):
+                nxt = wire[i]
+                if isinstance(nxt, list) and len(cast(list[object], nxt)) >= 2:
+                    nxt_row = cast(list[object], nxt)
+                    name = str(nxt_row[0]).lower()
+                    val = str(nxt_row[1]).lower()
                     if name == "read" and val in ("true", "1", "yes"):
                         mode = "read"
                         i += 1
diff --git a/src/imwald/core/relay_manager.py b/src/imwald/core/relay_manager.py
index 248761d..afdfe30 100644
--- a/src/imwald/core/relay_manager.py
+++ b/src/imwald/core/relay_manager.py
@@ -10,7 +10,7 @@ import random
 import time
 from dataclasses import dataclass, field
 from enum import Enum
-from typing import Any, Callable, Coroutine
+from typing import Any, Callable, Coroutine, cast
 
 import websockets
 from websockets.asyncio.client import ClientConnection
@@ -33,8 +33,8 @@ class RelayConn:
     last_error: str | None = None
     last_connected_at: float | None = None
     backoff_until: float = 0.0
-    _ws: ClientConnection | None = field(default=None, repr=False)
-    _task: asyncio.Task[None] | None = field(default=None, repr=False)
+    ws: ClientConnection | None = field(default=None, repr=False)
+    runner_task: asyncio.Task[None] | None = field(default=None, repr=False)
 
     def status_line(self) -> str:
         err = f" ({self.last_error})" if self.last_error else ""
@@ -80,38 +80,38 @@ class RelayManager:
     async def stop(self) -> None:
         self._shutdown.set()
         for r in self._relays.values():
-            if r._task:
-                r._task.cancel()
+            if r.runner_task:
+                r.runner_task.cancel()
                 with contextlib.suppress(asyncio.CancelledError):
-                    await r._task
-                r._task = None
-            if r._ws:
-                await r._ws.close()
-                r._ws = None
+                    await r.runner_task
+                r.runner_task = None
+            if r.ws:
+                await r.ws.close()
+                r.ws = None
 
     def request_subscribe(self, relay_url: str, sub_id: str, filters: list[dict[str, Any]]) -> None:
         relay_url = _normalize_ws_url(relay_url)
         self._subs[f"{relay_url}:{sub_id}"] = {"relay": relay_url, "sub_id": sub_id, "filters": filters}
-        if relay_url in self._relays and self._relays[relay_url]._ws:
+        if relay_url in self._relays and self._relays[relay_url].ws:
             asyncio.create_task(self._send_req(relay_url, sub_id, filters))
 
     async def _send_req(self, relay_url: str, sub_id: str, filters: list[dict[str, Any]]) -> None:
         r = self._relays.get(relay_url)
-        if not r or not r._ws:
+        if not r or not r.ws:
             return
         msg = json.dumps(["REQ", sub_id, *filters])
-        await r._ws.send(msg)
+        await r.ws.send(msg)
 
     async def _ensure_connected(self, url: str) -> None:
         r = self._relays[url]
         now = time.monotonic()
         if r.state == RelayState.BACKOFF and now < r.backoff_until:
             return
-        if r._ws and r.state == RelayState.CONNECTED:
+        if r.ws and r.state == RelayState.CONNECTED:
             return
-        if r._task and not r._task.done():
+        if r.runner_task and not r.runner_task.done():
             return
-        r._task = asyncio.create_task(self._run_relay(url))
+        r.runner_task = asyncio.create_task(self._run_relay(url))
 
     async def _run_relay(self, url: str) -> None:
         r = self._relays[url]
@@ -128,11 +128,11 @@ class RelayManager:
                     close_timeout=5,
                     max_size=2**22,
                 ) as ws:
-                    r._ws = ws
+                    r.ws = ws
                     r.state = RelayState.CONNECTED
                     r.last_connected_at = time.time()
                     # re-send subscriptions for this relay
-                    for key, sub in self._subs.items():
+                    for _, sub in self._subs.items():
                         if sub["relay"] == url:
                             await self._send_req(url, sub["sub_id"], sub["filters"])
                     attempt = 0
@@ -140,16 +140,17 @@ class RelayManager:
                         if self._shutdown.is_set():
                             break
                         try:
-                            msg = json.loads(raw)
+                            msg: object = json.loads(raw)
                         except json.JSONDecodeError:
                             continue
                         if not isinstance(msg, list) or not msg:
                             continue
-                        typ = msg[0]
-                        if typ == "EVENT" and len(msg) >= 3:
-                            await self._on_event(url, msg[2])
-                        elif typ == "NOTICE" and len(msg) >= 2 and self._on_notice:
-                            await self._on_notice(url, str(msg[1]))
+                        wire = cast(list[object], msg)
+                        typ: object = wire[0]
+                        if typ == "EVENT" and len(wire) >= 3 and isinstance(wire[2], dict):
+                            await self._on_event(url, cast(dict[str, Any], wire[2]))
+                        elif typ == "NOTICE" and len(wire) >= 2 and self._on_notice:
+                            await self._on_notice(url, str(wire[1]))
                         elif typ == "OK":
                             pass
             except Exception as e:  # noqa: BLE001
@@ -157,7 +158,7 @@ class RelayManager:
                 r.state = RelayState.ERROR
                 log.warning("relay %s error: %s", url, e)
             finally:
-                r._ws = None
+                r.ws = None
                 r.state = RelayState.BACKOFF
                 attempt += 1
                 delay = min(60.0, 1.5**attempt) + random.random()
diff --git a/src/imwald/ui/composer_dialog.py b/src/imwald/ui/composer_dialog.py
index 64d3fa4..8f34a0c 100644
--- a/src/imwald/ui/composer_dialog.py
+++ b/src/imwald/ui/composer_dialog.py
@@ -4,7 +4,7 @@ from __future__ import annotations
 
 import json
 import time
-from typing import Any
+from typing import Any, cast
 
 from PySide6.QtWidgets import (
     QComboBox,
@@ -17,6 +17,7 @@ from PySide6.QtWidgets import (
     QMessageBox,
     QSpinBox,
     QVBoxLayout,
+    QWidget,
 )
 
 from imwald.core.accounts_store import StoredAccount, unlock_secret
@@ -32,7 +33,7 @@ TAG_SUGGESTIONS = ["t", "client", "e", "p", "relay", "imeta"]
 class ComposerDialog(QDialog):
     def __init__(
         self,
-        parent=None,
+        parent: QWidget | None = None,
         *,
         edit_from: StoredEventRow | dict[str, Any] | None = None,
         account: StoredAccount,
@@ -96,9 +97,10 @@ class ComposerDialog(QDialog):
 
     def _publish(self) -> None:
         try:
-            tags = json.loads(self._tags.text() or "[]")
-            if not isinstance(tags, list):
+            tags_raw = json.loads(self._tags.text() or "[]")
+            if not isinstance(tags_raw, list):
                 raise ValueError("tags must be a JSON array")
+            tags = cast(list[list[str]], tags_raw)
         except Exception as e:  # noqa: BLE001
             QMessageBox.warning(self, "Invalid tags", str(e))
             return
@@ -117,7 +119,7 @@ class ComposerDialog(QDialog):
 
 
 def open_composer_for_edit(
-    parent,
+    parent: QWidget | None,
     ev: dict[str, Any],
     account: StoredAccount,
     password: str | None,
diff --git a/src/imwald/ui/db_admin_page.py b/src/imwald/ui/db_admin_page.py
index bf5c8bd..5373092 100644
--- a/src/imwald/ui/db_admin_page.py
+++ b/src/imwald/ui/db_admin_page.py
@@ -2,7 +2,7 @@
 
 from __future__ import annotations
 
-from PySide6.QtCore import Qt, Signal
+from PySide6.QtCore import Signal
 from PySide6.QtWidgets import (
     QComboBox,
     QHBoxLayout,
@@ -24,7 +24,9 @@ class DbAdminPage(QWidget):
     open_event = Signal(str)
     request_nip09 = Signal(str, str)  # event_id, signing_pubkey hex
 
-    def __init__(self, db: Database, accounts: list[StoredAccount], parent=None) -> None:
+    def __init__(
+        self, db: Database, accounts: list[StoredAccount], parent: QWidget | None = None
+    ) -> None:
         super().__init__(parent)
         self._db = db
         self._accounts = accounts
@@ -83,7 +85,7 @@ class DbAdminPage(QWidget):
         self._grid.setHorizontalHeaderLabels(cols)
         self._grid.setRowCount(len(rows))
         for ri, row in enumerate(rows):
-            for ci, c in enumerate(cols):
+            for ci, _ in enumerate(cols):
                 v = row[ci]
                 self._grid.setItem(ri, ci, QTableWidgetItem("" if v is None else str(v)))
         self._grid.setProperty("current_table", name)
@@ -93,7 +95,7 @@ class DbAdminPage(QWidget):
         name = self._grid.property("current_table")
         if name != "events":
             return None
-        cols = []
+        cols: list[str] = []
         for i in range(self._grid.columnCount()):
             hi = self._grid.horizontalHeaderItem(i)
             cols.append(hi.text() if hi is not None else "")
@@ -111,12 +113,12 @@ class DbAdminPage(QWidget):
         name = self._grid.property("current_table")
         if name != "events":
             return None
-        cols = []
+        cols_pk: list[str] = []
         for i in range(self._grid.columnCount()):
             hi = self._grid.horizontalHeaderItem(i)
-            cols.append(hi.text() if hi is not None else "")
+            cols_pk.append(hi.text() if hi is not None else "")
         try:
-            ci = cols.index("pubkey")
+            ci = cols_pk.index("pubkey")
         except ValueError:
             return None
         r = self._grid.currentRow()
@@ -139,7 +141,7 @@ class DbAdminPage(QWidget):
         self._grid.setHorizontalHeaderLabels(cols)
         self._grid.setRowCount(len(rows))
         for ri, row in enumerate(rows):
-            for ci, c in enumerate(cols):
+            for ci, _ in enumerate(cols):
                 v = row[ci]
                 self._grid.setItem(ri, ci, QTableWidgetItem("" if v is None else str(v)))
         self._nip_btn.setVisible(False)
diff --git a/src/imwald/ui/feed_page.py b/src/imwald/ui/feed_page.py
index 4d0d463..50865ac 100644
--- a/src/imwald/ui/feed_page.py
+++ b/src/imwald/ui/feed_page.py
@@ -4,10 +4,12 @@ from __future__ import annotations
 
 import html
 import json
+from collections.abc import Sequence
 from typing import Any, cast
 
 from PySide6.QtCore import QEvent, QObject, Qt, QTimer
 from PySide6.QtGui import QKeyEvent, QTextOption
+
 from PySide6.QtWidgets import (
     QFrame,
     QHBoxLayout,
@@ -37,8 +39,6 @@ FEED_KINDS = (1, 20, 21, 30023, 9802, 11)
 def _set_plain_height_to_content(te: QPlainTextEdit) -> None:
     doc = te.document()
     lay = doc.documentLayout()
-    if lay is None:
-        return
     vw = te.viewport().width()
     if vw < 50:
         outer = max(te.width(), 120)
@@ -68,9 +68,26 @@ def _format_engagement_html(stats: dict[str, Any]) -> str:
         parts.append(f"💬&nbsp;<b>{q}</b>")
     if rep:
         parts.append(f"↩&nbsp;<b>{rep}</b>")
-    rx = stats.get("reaction_breakdown") or []
+    rx_raw = stats.get("reaction_breakdown")
+    pairs: list[tuple[str, int]] = []
+    if isinstance(rx_raw, list):
+        for pair_obj in cast(list[object], rx_raw)[:18]:
+            if not isinstance(pair_obj, (list, tuple)):
+                continue
+            pseq = cast(Sequence[object], pair_obj)
+            if len(pseq) < 2:
+                continue
+            em_o, c_o = pseq[0], pseq[1]
+            em = em_o if isinstance(em_o, str) else str(em_o)
+            if isinstance(c_o, bool):
+                c = int(c_o)
+            elif isinstance(c_o, (int, float)):
+                c = int(c_o)
+            else:
+                c = int(str(c_o)) if str(c_o).isdigit() else 0
+            pairs.append((em, c))
     emoji_bits: list[str] = []
-    for em, c in rx[:18]:
+    for em, c in pairs:
         e = html.escape(em if em != "+" else "❤", quote=False)
         if c > 1:
             emoji_bits.append(f'<span style="font-size:21px" title="{e}×{c}">{e}<sub style="font-size:13px">{c}</sub></span>')
@@ -86,7 +103,7 @@ def _format_engagement_html(stats: dict[str, Any]) -> str:
 
 
 class FeedPage(QWidget):
-    def __init__(self, db: Database, engine: NostrEngine, parent=None) -> None:
+    def __init__(self, db: Database, engine: NostrEngine, parent: QWidget | None = None) -> None:
         super().__init__(parent)
         self.setObjectName("FeedPage")
         self._db = db
diff --git a/src/imwald/ui/main_window.py b/src/imwald/ui/main_window.py
index 7144eb0..1879689 100644
--- a/src/imwald/ui/main_window.py
+++ b/src/imwald/ui/main_window.py
@@ -2,8 +2,10 @@
 
 from __future__ import annotations
 
+from typing import Any, cast
+
 from PySide6.QtCore import Qt, QTimer
-from PySide6.QtGui import QAction
+from PySide6.QtGui import QAction, QCloseEvent
 from PySide6.QtWidgets import (
     QComboBox,
     QDialog,
@@ -17,6 +19,7 @@ from PySide6.QtWidgets import (
     QStackedWidget,
     QToolBar,
     QVBoxLayout,
+    QWidget,
 )
 
 from imwald.core.accounts_store import StoredAccount, load_accounts
@@ -34,7 +37,7 @@ from imwald.ui.search_page import SearchPage
 
 
 class MainWindow(QMainWindow):
-    def __init__(self, *, db: Database, engine: NostrEngine, parent=None) -> None:
+    def __init__(self, *, db: Database, engine: NostrEngine, parent: QWidget | None = None) -> None:
         super().__init__(parent)
         self.setWindowTitle("imwald")
         self.resize(1200, 820)
@@ -160,7 +163,7 @@ class MainWindow(QMainWindow):
         m_file.addAction(a_onb)
 
         m_view = self.menuBar().addMenu("&View")
-        for i, (title, idx) in enumerate(
+        for _, (title, idx) in enumerate(
             [
                 ("&Feed", 0),
                 ("&Search", 1),
@@ -190,12 +193,15 @@ class MainWindow(QMainWindow):
 
     def _wire_engine(self) -> None:
         self._engine.event_ingested.connect(self._on_event_ingested)
-        self._engine.relay_status.connect(lambda s: self.statusBar().showMessage(s, 8000))
+        self._engine.relay_status.connect(self._relay_status_message)
+
+    def _relay_status_message(self, s: str) -> None:
+        self.statusBar().showMessage(s, 8000)
 
     def _on_event_ingested(self, relay_url: str, ev: object) -> None:
         if not isinstance(ev, dict):
             return
-        NostrEngine.apply_ingest_to_db(self._db, ev, relay_url)
+        NostrEngine.apply_ingest_to_db(self._db, cast(dict[str, Any], ev), relay_url)
         self._ingest_ui_timer.start()
 
     def _wire_pages(self) -> None:
@@ -301,6 +307,6 @@ class MainWindow(QMainWindow):
             return None, None
         return acc, self._password_for(pk)
 
-    def closeEvent(self, event) -> None:  # noqa: N802
+    def closeEvent(self, event: QCloseEvent) -> None:  # noqa: N802
         self._engine.stop_relays()
         super().closeEvent(event)
diff --git a/src/imwald/ui/notifications_page.py b/src/imwald/ui/notifications_page.py
index 328e4c1..aad5a87 100644
--- a/src/imwald/ui/notifications_page.py
+++ b/src/imwald/ui/notifications_page.py
@@ -16,7 +16,9 @@ class NotificationsPage(QWidget):
     open_event = Signal(str)
     signing_pubkey_changed = Signal(str)
 
-    def __init__(self, db: Database, accounts: list[StoredAccount], parent=None) -> None:
+    def __init__(
+        self, db: Database, accounts: list[StoredAccount], parent: QWidget | None = None
+    ) -> None:
         super().__init__(parent)
         self._db = db
         self._accounts = accounts
diff --git a/src/imwald/ui/onboarding_wizard.py b/src/imwald/ui/onboarding_wizard.py
index 2db19bb..98061e0 100644
--- a/src/imwald/ui/onboarding_wizard.py
+++ b/src/imwald/ui/onboarding_wizard.py
@@ -13,6 +13,7 @@ from PySide6.QtWidgets import (
     QMessageBox,
     QPlainTextEdit,
     QVBoxLayout,
+    QWidget,
     QWizard,
     QWizardPage,
 )
@@ -83,6 +84,9 @@ class PageProfile(QWizardPage):
         self._about = QPlainTextEdit()
         form.addRow("About", self._about)
 
+    def about_text(self) -> str:
+        return self._about.toPlainText().strip()
+
     def nextId(self) -> int:
         return PAGE_INTERESTS
 
@@ -100,6 +104,14 @@ class PageInterests(QWizardPage):
             self._list.addItem(it)
         lay.addWidget(self._list)
 
+    def selected_interests(self) -> list[str]:
+        out: list[str] = []
+        for i in range(self._list.count()):
+            it = self._list.item(i)
+            if it.checkState() == Qt.CheckState.Checked:
+                out.append(it.text().lstrip("#"))
+        return out
+
     def nextId(self) -> int:
         return PAGE_LANG
 
@@ -144,6 +156,9 @@ class PageSafety(QWizardPage):
         self._hide.setChecked(True)
         lay.addWidget(self._hide)
 
+    def hide_nsfw_recommended(self) -> bool:
+        return self._hide.isChecked()
+
     def nextId(self) -> int:
         wiz = self.wizard()
         intro = wiz.page(PAGE_INTRO) if wiz else None
@@ -165,9 +180,12 @@ class PagePassword(QWizardPage):
         form.addRow("Password", self._pw)
         form.addRow("Repeat", self._pw2)
 
+    def password_pair(self) -> tuple[str, str]:
+        return self._pw.text(), self._pw2.text()
+
 
 def run_onboarding_wizard(
-    parent,
+    parent: QWidget | None,
     *,
     db: Database,
     engine: NostrEngine,
@@ -192,14 +210,14 @@ def run_onboarding_wizard(
     if w.exec() != QWizard.DialogCode.Accepted:
         return False
 
-    hide_nsfw = "1" if p4._hide.isChecked() else "0"  # noqa: SLF001
+    hide_nsfw = "1" if p4.hide_nsfw_recommended() else "0"
     db.set_setting("hide_nsfw", hide_nsfw)
 
-    if p0.lurk():  # noqa: SLF001
+    if p0.lurk():
         return True
 
-    pw = p5._pw.text()  # noqa: SLF001
-    if pw != p5._pw2.text():  # noqa: SLF001
+    pw, pw2 = p5.password_pair()
+    if pw != pw2:
         QMessageBox.warning(parent, "Password mismatch", "Passwords do not match.")
         return False
     password = pw if pw else None
@@ -211,18 +229,14 @@ def run_onboarding_wizard(
     existing_accounts.append(acc)
     save_accounts(existing_accounts)
 
-    interests = []
-    for i in range(p2._list.count()):  # noqa: SLF001
-        it = p2._list.item(i)  # noqa: SLF001
-        if it.checkState() == Qt.CheckState.Checked:
-            interests.append(it.text().lstrip("#"))
+    interests = p2.selected_interests()
 
-    langs = p3.selected()  # noqa: SLF001
+    langs = p3.selected()
     engine.publish_kind0_and_lists(
         acc,
         password,
         username=nature_label,
-        about=p1._about.toPlainText().strip(),
+        about=p1.about_text(),
         interest_tags=interests,
         languages=langs,
     )
diff --git a/src/imwald/ui/search_page.py b/src/imwald/ui/search_page.py
index 4adaf85..9a360f2 100644
--- a/src/imwald/ui/search_page.py
+++ b/src/imwald/ui/search_page.py
@@ -12,7 +12,7 @@ from imwald.core.md_render import markdown_plain_summary
 class SearchPage(QWidget):
     open_event = Signal(str)
 
-    def __init__(self, db: Database, parent=None) -> None:
+    def __init__(self, db: Database, parent: QWidget | None = None) -> None:
         super().__init__(parent)
         self._db = db
         self._q = QLineEdit()
diff --git a/tests/test_kind30000_lists.py b/tests/test_kind30000_lists.py
index ad63b67..d948620 100644
--- a/tests/test_kind30000_lists.py
+++ b/tests/test_kind30000_lists.py
@@ -1,5 +1,6 @@
 import tempfile
 from pathlib import Path
+from typing import Any
 
 from imwald.core.database import Database
 from imwald.core.nostr_crypto import build_signed_event
@@ -33,8 +34,22 @@ def test_ranker_follow_beats_kind30000() -> None:
         me = "f" * 64
         follow_pk = "a" * 64
         list_pk = "b" * 64
-        ev_f = {"id": "1" * 64, "pubkey": follow_pk, "created_at": 1, "kind": 1, "tags": [], "content": "x"}
-        ev_l = {"id": "2" * 64, "pubkey": list_pk, "created_at": 2, "kind": 1, "tags": [], "content": "y"}
+        ev_f: dict[str, Any] = {
+            "id": "1" * 64,
+            "pubkey": follow_pk,
+            "created_at": 1,
+            "kind": 1,
+            "tags": [],
+            "content": "x",
+        }
+        ev_l: dict[str, Any] = {
+            "id": "2" * 64,
+            "pubkey": list_pk,
+            "created_at": 2,
+            "kind": 1,
+            "tags": [],
+            "content": "y",
+        }
         sf, _ = r.score_event(ev_f, my_pubkey=me, following={follow_pk}, list30000_pubkeys={list_pk})
         sl, _ = r.score_event(ev_l, my_pubkey=me, following={follow_pk}, list30000_pubkeys={list_pk})
         assert sf > sl
diff --git a/typings/quickjs.pyi b/typings/quickjs.pyi
new file mode 100644
index 0000000..5fed52e
--- /dev/null
+++ b/typings/quickjs.pyi
@@ -0,0 +1,5 @@
+"""Partial stubs for the ``quickjs`` module (``quickjs-ng`` runtime)."""
+
+class Context:
+    def __init__(self) -> None: ...
+    def eval(self, code: str, /) -> object: ...