broken in db49a75069
playwright version installed by yarn needs to match version in nix
otherwise playwright will try and use a version of
chromium not installed
storybook also stopped working after the `yarn upgrade` commit above
so the 'jackspeak' workaround needed to be reintroduced
turned off with feature stapling. requires:
* styles to be improved (inline image links, respecting html img sizing, etc)
* intergration into its own tab (potentially sepearte routing
for proposal, issues, readme)
* proxy to get readme via git for all git sources
- display the commit message from the patch content if description tag
is not present
- fix '[unknown commit id]' display
to run typescript tests ts-ject was added as a dev dependancy
This applies a really basic version of the parsing in
ndk-svelte-components which was copied from coracle. hopefully they can
be fully aligned in the future. I applied extra typing and will
intergrate other ParsedParts when needed.
applied line breaks to commit messages, pr description and default for
event content.
add dependancies to enable tests to run
there is a slight missmatch in html classes in `js.snap` test vectors
when tests are run with storybook is built using `storybook dev` vs
`storybook build`
7777e06a added a dependancy on playwright which wouldn't run in
nix-shell without extra configuration.
the simpliest configuration (used in this commit) required a more
recent version of nixpkgs unstable. unfortunately these more recent
versions introduce a 'system limit for file watchers reached' bug in
storybook's server when run on linux. This can be mitigated by
manually increasing the watcher limit.
attempts to fix the playwright nixpkgs dependancies to different
versions still introduced the bug
hopefully the bug will disapear in newer releases of nixpkgs unstable
add image and dom snapshot comparison for storybook components
image snapshot comparison can been flaky and produce many
false-positives. a higher threshold has been used to mitigate this
although it may not identify all regressions. DOM snapshots
supplement images to increase the likelihood of capturing
regressions.
consideration was given to using a shared library built in rust
for this and the cli utility but this was discounted for these
reasons:
1. different data storage and caching requirements
2. ndk is more mature and has extra features for building web
apps
3. use of shared svelte components in ndk
4. prospect of contributing git specific components to ndk to
encourage adoption among other clientus
start with a nix boilerplate for svelte that supports reproducible
builds
taken unedited from https://github.com/knarkzel/sveltekit-nix
c444859e97fb13393ad6e295132412bbea044e32
DanConwayDev
jk
jk