diff --git a/__snapshots__/repo-details--one-maintainer-s-profile-has-no-display-name-or-name.png b/__snapshots__/repo-details--one-maintainer-s-profile-has-no-display-name-or-name.png new file mode 100644 index 0000000..793a6ad Binary files /dev/null and b/__snapshots__/repo-details--one-maintainer-s-profile-has-no-display-name-or-name.png differ diff --git a/__snapshots__/repo-details--one-maintainer-s-profile-not-loaded.png b/__snapshots__/repo-details--one-maintainer-s-profile-not-loaded.png new file mode 100644 index 0000000..d1d1c1d Binary files /dev/null and b/__snapshots__/repo-details--one-maintainer-s-profile-not-loaded.png differ diff --git a/__snapshots__/repo-details--one-maintainer-s-profile-only-has-display-name-but-no-name.png b/__snapshots__/repo-details--one-maintainer-s-profile-only-has-display-name-but-no-name.png new file mode 100644 index 0000000..252e554 Binary files /dev/null and b/__snapshots__/repo-details--one-maintainer-s-profile-only-has-display-name-but-no-name.png differ diff --git a/__snapshots__/repo-details.test.js.snap b/__snapshots__/repo-details.test.js.snap index 530aff4..9c94843 100644 --- a/__snapshots__/repo-details.test.js.snap +++ b/__snapshots__/repo-details.test.js.snap @@ -365,6 +365,164 @@ exports[`Repo/Details No Tags test 1`] = ` `; +exports[`Repo/Details One Maintainer's Profile Has No displayName or Name test 1`] = ` +
+

+ description +

+

+ short description +

+
+
+ svelte +
+
+ nostr +
+
+ code-collaboration +
+
+ git +
+
+
+

+ maintainers +

+
+ carole +
+
+ cannot find name +
+
+ steve +
+
+
+

+ relays +

+
+ relay.damus.io +
+
+ relay.snort.social +
+
+ relayable.org +
+
+
+`; + +exports[`Repo/Details One Maintainer's Profile Not Loaded test 1`] = ` +
+

+ description +

+

+ short description +

+
+
+ svelte +
+
+ nostr +
+
+ code-collaboration +
+
+ git +
+
+
+

+ maintainers +

+
+ carole +
+
+
+
+ steve +
+
+
+

+ relays +

+
+ relay.damus.io +
+
+ relay.snort.social +
+
+ relayable.org +
+
+
+`; + +exports[`Repo/Details One Maintainer's Profile Only Has displayName But No Name test 1`] = ` +
+

+ description +

+

+ short description +

+
+
+ svelte +
+
+ nostr +
+
+ code-collaboration +
+
+ git +
+
+
+

+ maintainers +

+
+ carole +
+
+ bob +
+
+ steve +
+
+
+

+ relays +

+
+ relay.damus.io +
+
+ relay.snort.social +
+
+ relayable.org +
+
+
+`; + exports[`Repo/Details Short Details test 1`] = `

diff --git a/src/lib/components/Repo.vectors.ts b/src/lib/components/Repo.vectors.ts index cb827a7..970a68e 100644 --- a/src/lib/components/Repo.vectors.ts +++ b/src/lib/components/Repo.vectors.ts @@ -1,5 +1,6 @@ import type { Args as SummaryCardArgs } from "./RepoSummaryCard.svelte"; import type { Args as DetailsArgs } from "./RepoDetails.svelte"; +import type { NDKUserProfile } from "@nostr-dev-kit/ndk"; export let RepoSummaryCardArgsVectors = { Short: { @@ -29,9 +30,9 @@ let base: DetailsArgs = { "relayable.org", ], maintainers: [ - "carole", - "bob", - "steve", + { name: "carole" } as NDKUserProfile, + { name: "bob" } as NDKUserProfile, + { name: "steve" } as NDKUserProfile, ], }; @@ -52,6 +53,40 @@ export let RepoDetailsArgsVectors = { NoNameOrDescription: { ...base, name: "", description: "" } as DetailsArgs, NoDescription: { ...base, description: "" } as DetailsArgs, NoTags: { ...base, tags: [] } as DetailsArgs, + MaintainersOneProfileNotLoaded: { + ...base, maintainers: [ + { name: "carole" } as NDKUserProfile, + "pubkey", + { name: "steve" } as NDKUserProfile, + + ] + } as DetailsArgs, + MaintainersOneProfileDisplayNameWithoutName: { + ...base, maintainers: [ + { name: "carole" } as NDKUserProfile, + { displayName: "bob" } as NDKUserProfile, + { name: "steve" } as NDKUserProfile, + + ] + } as DetailsArgs, + MaintainersOneProfileNameAndDisplayNamePresent: { + ...base, maintainers: [ + { name: "carole" } as NDKUserProfile, + { + name: "bob", displayName: "shouldnt display" + } as NDKUserProfile, + { name: "steve" } as NDKUserProfile, + + ] + } as DetailsArgs, + MaintainersOneProfileNoNameOrDisplayNameBeingPresent: { + ...base, maintainers: [ + { name: "carole" } as NDKUserProfile, + {} as NDKUserProfile, + { name: "steve" } as NDKUserProfile, + + ] + } as DetailsArgs, NoMaintainers: { ...base, maintainers: [] } as DetailsArgs, NoRelays: { ...base, relays: [] } as DetailsArgs, NoMaintainersOrRelays: { ...base, maintainers: [], relays: [] } as DetailsArgs, diff --git a/src/lib/components/RepoDetails.stories.svelte b/src/lib/components/RepoDetails.stories.svelte index ce905ea..b5abac6 100644 --- a/src/lib/components/RepoDetails.stories.svelte +++ b/src/lib/components/RepoDetails.stories.svelte @@ -29,6 +29,21 @@ + + + + + + diff --git a/src/lib/components/RepoDetails.svelte b/src/lib/components/RepoDetails.svelte index 41202d0..9fc9d2e 100644 --- a/src/lib/components/RepoDetails.svelte +++ b/src/lib/components/RepoDetails.svelte @@ -1,11 +1,13 @@