silberengel
/
gitcitadel-online
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

feat(RepoPage): add avatar next to pr author name 

by using UserHeader now a xs inline option is available
master
DanConwayDev 2 years ago
parent
65ad8e5aac
commit
6f6019b32d
No known key found for this signature in database
GPG Key ID: 68E15486D73F75E1
12 changed files with 223 additions and 20 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. BIN
      __snapshots__/prs-list-item--long-details.png
  2. BIN
      __snapshots__/prs-list-item--short-details.png
  3. BIN
      __snapshots__/prs-list-item--status-closed.png
  4. BIN
      __snapshots__/prs-list-item--status-draft.png
  5. BIN
      __snapshots__/prs-list-item--status-loading.png
  6. BIN
      __snapshots__/prs-list-item--status-merged.png
  7. 124
      __snapshots__/prs-list-item.test.js.snap
  8. BIN
      __snapshots__/prs-list-list--default.png
  9. BIN
      __snapshots__/prs-list-list--no-title.png
  10. BIN
      __snapshots__/prs-list-list--partially-loaded.png
  11. 112
      __snapshots__/prs-list-list.test.js.snap
  12. 7
      src/lib/components/prs/PRsListItem.svelte

BIN
__snapshots__/prs-list-item--long-details.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 14 KiB

After

Width:  |  Height:  |  Size: 15 KiB

BIN
__snapshots__/prs-list-item--short-details.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 12 KiB

BIN
__snapshots__/prs-list-item--status-closed.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 12 KiB

BIN
__snapshots__/prs-list-item--status-draft.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 12 KiB

BIN
__snapshots__/prs-list-item--status-loading.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 12 KiB

BIN
__snapshots__/prs-list-item--status-merged.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 12 KiB

124
__snapshots__/prs-list-item.test.js.snap
Unescape View File

@ -30,7 +30,17 @@ exports[`PRs/List/Item Author Loading smoke-test 1`] = ` @@ -30,7 +30,17 @@ exports[`PRs/List/Item Author Loading smoke-test 1`] = `
opened 3 months ago
</li>
<li class="inline">
<div class="skeleton inline-block h-3 w-20 pb-2">
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5 skeleton">
</div>
</div>
<div class="pl-0 inline-block">
<div class="skeleton w-24 h-2.5">
</div>
</div>
</div>
</div>
</li>
</ul>
@ -58,7 +68,21 @@ exports[`PRs/List/Item Long Details smoke-test 1`] = ` @@ -58,7 +68,21 @@ exports[`PRs/List/Item Long Details smoke-test 1`] = `
opened a minute ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -95,7 +119,21 @@ exports[`PRs/List/Item Long and No Spaces smoke-test 1`] = ` @@ -95,7 +119,21 @@ exports[`PRs/List/Item Long and No Spaces smoke-test 1`] = `
opened 3 months ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -132,7 +170,21 @@ exports[`PRs/List/Item Short Details smoke-test 1`] = ` @@ -132,7 +170,21 @@ exports[`PRs/List/Item Short Details smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -169,7 +221,21 @@ exports[`PRs/List/Item Status Closed smoke-test 1`] = ` @@ -169,7 +221,21 @@ exports[`PRs/List/Item Status Closed smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -206,7 +272,21 @@ exports[`PRs/List/Item Status Draft smoke-test 1`] = ` @@ -206,7 +272,21 @@ exports[`PRs/List/Item Status Draft smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -238,7 +318,21 @@ exports[`PRs/List/Item Status Loading smoke-test 1`] = ` @@ -238,7 +318,21 @@ exports[`PRs/List/Item Status Loading smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -275,7 +369,21 @@ exports[`PRs/List/Item Status Merged smoke-test 1`] = ` @@ -275,7 +369,21 @@ exports[`PRs/List/Item Status Merged smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>

BIN
__snapshots__/prs-list-list--default.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 31 KiB

After

Width:  |  Height:  |  Size: 33 KiB

BIN
__snapshots__/prs-list-list--no-title.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 19 KiB

After

Width:  |  Height:  |  Size: 21 KiB

BIN
__snapshots__/prs-list-list--partially-loaded.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 22 KiB

After

Width:  |  Height:  |  Size: 24 KiB

112
__snapshots__/prs-list-list.test.js.snap
Unescape View File

@ -37,7 +37,21 @@ exports[`PRs/List/List Default smoke-test 1`] = ` @@ -37,7 +37,21 @@ exports[`PRs/List/List Default smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -61,7 +75,21 @@ exports[`PRs/List/List Default smoke-test 1`] = ` @@ -61,7 +75,21 @@ exports[`PRs/List/List Default smoke-test 1`] = `
opened a minute ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -95,7 +123,21 @@ exports[`PRs/List/List Default smoke-test 1`] = ` @@ -95,7 +123,21 @@ exports[`PRs/List/List Default smoke-test 1`] = `
opened 3 months ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -199,7 +241,21 @@ exports[`PRs/List/List No Title smoke-test 1`] = ` @@ -199,7 +241,21 @@ exports[`PRs/List/List No Title smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -223,7 +279,21 @@ exports[`PRs/List/List No Title smoke-test 1`] = ` @@ -223,7 +279,21 @@ exports[`PRs/List/List No Title smoke-test 1`] = `
opened a minute ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -269,7 +339,21 @@ exports[`PRs/List/List Partially Loaded smoke-test 1`] = ` @@ -269,7 +339,21 @@ exports[`PRs/List/List Partially Loaded smoke-test 1`] = `
opened 7 days ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>
@ -293,7 +377,21 @@ exports[`PRs/List/List Partially Loaded smoke-test 1`] = ` @@ -293,7 +377,21 @@ exports[`PRs/List/List Partially Loaded smoke-test 1`] = `
opened a minute ago
</li>
<li class="inline">
DanConwayDev
<div class="inline-block">
<div class="text-xs align-middle">
<div class="avatar inline-block align-middle">
<div class="rounded inline-block h-3.5 w-3.5">
<img class="my-0"
src="../test-profile-image.jpg"
alt="DanConwayDev"
>
</div>
</div>
<div class="pl-0 inline-block">
DanConwayDev
</div>
</div>
</div>
</li>
</ul>
</a>

7
src/lib/components/prs/PRsListItem.svelte
Unescape View File

@ -7,6 +7,7 @@ @@ -7,6 +7,7 @@
import { summary_defaults } from './type'
import { getName } from '../users/type'
import { pr_icon_path } from './icons'
import UserHeader from '../users/UserHeader.svelte'
dayjs.extend(relativeTime)
export let {
@ -102,11 +103,7 @@ @@ -102,11 +103,7 @@
opened {created_at_ago}
</li>
<li class="inline">
{#if author.loading}
<div class="skeleton inline-block h-3 w-20 pb-2"></div>
{:else}
{author_name}
{/if}
<UserHeader user={author} inline={true} size="xs" />
</li>
</ul>
{/if}

Write Preview
Loading…
Cancel
Save