Browse Source

build: change loading behaviour to fix tests

repo summary loading spinner caused intermittant test failures
master
DanConwayDev 2 years ago
parent
commit
07e8190713
No known key found for this signature in database
GPG Key ID: 68E15486D73F75E1
  1. BIN
      __snapshots__/repo-summary-card--loading.png
  2. 6
      __snapshots__/repo-summary-card.test.js.snap
  3. BIN
      __snapshots__/repo-summary-list--loading.png
  4. BIN
      __snapshots__/repo-summary-list--partially-loaded.png
  5. 24
      __snapshots__/repo-summary-list.test.js.snap
  6. 3
      src/lib/components/RepoSummaryCard.svelte

BIN
__snapshots__/repo-summary-card--loading.png

Binary file not shown.

Before

Width:  |  Height:  |  Size: 6.2 KiB

After

Width:  |  Height:  |  Size: 6.9 KiB

6
__snapshots__/repo-summary-card.test.js.snap

@ -63,8 +63,10 @@ exports[`Repo/Summary/Card loading smoke-test 1`] = ` @@ -63,8 +63,10 @@ exports[`Repo/Summary/Card loading smoke-test 1`] = `
<div class="card w-96 bg-neutral text-neutral-focus">
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100">
</span>
<div class="h-6 mt-1 mb-3 skeleton w-40">
</div>
<div class="h-4 mb-1 skeleton w-100">
</div>
</div>
</div>
</div>

BIN
__snapshots__/repo-summary-list--loading.png

Binary file not shown.

Before

Width:  |  Height:  |  Size: 10 KiB

After

Width:  |  Height:  |  Size: 12 KiB

BIN
__snapshots__/repo-summary-list--partially-loaded.png

Binary file not shown.

Before

Width:  |  Height:  |  Size: 28 KiB

After

Width:  |  Height:  |  Size: 28 KiB

24
__snapshots__/repo-summary-list.test.js.snap

@ -69,24 +69,30 @@ exports[`Repo/Summary/List Loading smoke-test 1`] = ` @@ -69,24 +69,30 @@ exports[`Repo/Summary/List Loading smoke-test 1`] = `
<div class="card w-96 bg-neutral text-neutral-focus">
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100">
</span>
<div class="h-6 mt-1 mb-3 skeleton w-40">
</div>
<div class="h-4 mb-1 skeleton w-100">
</div>
</div>
</div>
</div>
<div class="card w-96 bg-neutral text-neutral-focus">
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100">
</span>
<div class="h-6 mt-1 mb-3 skeleton w-40">
</div>
<div class="h-4 mb-1 skeleton w-100">
</div>
</div>
</div>
</div>
<div class="card w-96 bg-neutral text-neutral-focus">
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100">
</span>
<div class="h-6 mt-1 mb-3 skeleton w-40">
</div>
<div class="h-4 mb-1 skeleton w-100">
</div>
</div>
</div>
</div>
@ -156,8 +162,10 @@ exports[`Repo/Summary/List Partially Loaded smoke-test 1`] = ` @@ -156,8 +162,10 @@ exports[`Repo/Summary/List Partially Loaded smoke-test 1`] = `
<div class="card w-96 bg-neutral text-neutral-focus">
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100">
</span>
<div class="h-6 mt-1 mb-3 skeleton w-40">
</div>
<div class="h-4 mb-1 skeleton w-100">
</div>
</div>
</div>
</div>

3
src/lib/components/RepoSummaryCard.svelte

@ -34,7 +34,8 @@ @@ -34,7 +34,8 @@
>
<div class="card-body">
<div class="text-center">
<span class="loading loading-spinner loading-lg text-base-100" />
<div class="h-6 mt-1 mb-3 skeleton w-40"></div>
<div class="h-4 mb-1 skeleton w-100"></div>
</div>
</div>
</div>

Loading…
Cancel
Save